Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM Batch] Support out-of-order UDF outputs #50169

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Feb 1, 2025

Why are these changes needed?

The processor stage UDF may output the rows out of order to achieve better streaming, because in this case we won't be blocked by a particular slow request. To achieve this, we attach __idx_in_batch to each row before sending to the UDF, and enforce all UDFs to carry this column in the outputs.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@comaniac comaniac requested a review from a team as a code owner February 1, 2025 01:14
@comaniac comaniac requested a review from kouroshHakha February 1, 2025 01:15
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
@comaniac comaniac added actor-based-usecase Issues when running large scale actor-based usecases. go add ONLY when ready to merge, run all tests and removed actor-based-usecase Issues when running large scale actor-based usecases. labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants